Remove detach from TensorImpl, handle via Type.#11337
Closed
gchanan wants to merge 1 commit intopytorch:masterfrom
Closed
Remove detach from TensorImpl, handle via Type.#11337gchanan wants to merge 1 commit intopytorch:masterfrom
gchanan wants to merge 1 commit intopytorch:masterfrom
Conversation
This is so that TensorImpl does not have to depend on Tensor.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
reviewed
Sep 6, 2018
| return self.clone(); | ||
| } | ||
|
|
||
| Tensor VariableType::detach(const Tensor & self) const { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Sep 7, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 7, 2018
Summary: This is so that TensorImpl does not have to depend on Tensor. Pull Request resolved: pytorch/pytorch#11337 Differential Revision: D9684421 Pulled By: gchanan fbshipit-source-id: d2af93420ca6d493429c251cfe5a34e9289c4484
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: This is so that TensorImpl does not have to depend on Tensor. Pull Request resolved: pytorch#11337 Differential Revision: D9684421 Pulled By: gchanan fbshipit-source-id: d2af93420ca6d493429c251cfe5a34e9289c4484
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so that TensorImpl does not have to depend on Tensor.