[build] Force third_party Eigen from setup.py#11334
Closed
orionr wants to merge 1 commit intopytorch:masterfrom
Closed
[build] Force third_party Eigen from setup.py#11334orionr wants to merge 1 commit intopytorch:masterfrom
orionr wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
|
Remind me why we build with Eigen enabled by default? |
Contributor
Author
|
Eigen is required for a large number of the Caffe2 operators. We need to have a version of Eigen available for those, but the third_party version should work in almost all cases. |
Contributor
|
Test failures seem irrelevant - let's land this? |
Yangqing
approved these changes
Sep 6, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: We shouldn't use system Eigen in any cases when building with setup.py. If people want to use system Eigen (not from third_party) they can build with CMake for now. Pull Request resolved: pytorch#11334 Reviewed By: pjh5 Differential Revision: D9689450 Pulled By: orionr fbshipit-source-id: baf616b9f195692942151ad201611dcfe7d927ba
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We shouldn't use system Eigen in any cases when building with setup.py. If people want to use system Eigen (not from third_party) they can build with CMake for now.