Static assert GetMutable is not passed with Tensor argument#11323
Closed
Static assert GetMutable is not passed with Tensor argument#11323
Conversation
Differential Revision: D9676205 Differential Version: 57041071
Yangqing
approved these changes
Sep 6, 2018
Contributor
|
wait I feel it should be rejected by the previous assert since Tensor is not default constructible? |
Contributor
Author
|
@jerryzh168 That used to be true, but when I turned |
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
…11323) Summary: Pull Request resolved: pytorch#11323 If you do pass it this, you'll get a pointer to UndefinedTensor; probably not what you want! Reviewed By: Yangqing Differential Revision: D9676205 fbshipit-source-id: 0bd3c22c2c40ac2958f95fc7a73b908af291cf22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Static assert GetMutable is not passed with Tensor argument
If you do pass it this, you'll get a pointer to
UndefinedTensor; probably not what you want!
Differential Revision: D9676205