Skip to content

caffe2::StorageImpl use at::DataPtr#11282

Closed
cpuhrsch wants to merge 1 commit intopytorch:masterfrom
cpuhrsch:export-D9658503
Closed

caffe2::StorageImpl use at::DataPtr#11282
cpuhrsch wants to merge 1 commit intopytorch:masterfrom
cpuhrsch:export-D9658503

Conversation

@cpuhrsch
Copy link
Copy Markdown
Contributor

@cpuhrsch cpuhrsch commented Sep 5, 2018 •
edited
Loading

facebook-github-bot
facebook-github-bot reviewed Sep 5, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ezyang
ezyang reviewed Sep 6, 2018
View reviewed changes
Comment thread caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 6, 2018
View reviewed changes
Comment thread caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

@cpuhrsch cpuhrsch changed the title caffe2::StorageImpl use numel_ instead of capacity_ [WIP] caffe2::StorageImpl use numel_ instead of capacity_ Sep 6, 2018
ezyang
ezyang reviewed Sep 9, 2018
View reviewed changes
Comment thread caffe2/contrib/aten/aten_op_template.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 10, 2018
View reviewed changes
Comment thread caffe2/python/pybind_state_dlpack.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 10, 2018
View reviewed changes
Comment thread caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 10, 2018
View reviewed changes
Comment thread caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 10, 2018
View reviewed changes
Comment thread caffe2/core/tensor.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 10, 2018
View reviewed changes
Comment thread caffe2/core/tensor.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 10, 2018
View reviewed changes
Comment thread caffe2/core/tensor.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 10, 2018
View reviewed changes
Comment thread caffe2/contrib/aten/aten_op_template.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 10, 2018
View reviewed changes
Comment thread caffe2/contrib/aten/aten_op_template.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 10, 2018
View reviewed changes
Comment thread caffe2/contrib/aten/aten_op_template.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@cpuhrsch cpuhrsch changed the title [WIP] caffe2::StorageImpl use numel_ instead of capacity_ [pytorch][PR] caffe2::StorageImpl use at::DataPtr Sep 11, 2018
@cpuhrsch cpuhrsch changed the title [pytorch][PR] caffe2::StorageImpl use at::DataPtr caffe2::StorageImpl use at::DataPtr Sep 11, 2018
ezyang
ezyang reviewed Sep 11, 2018
View reviewed changes
Comment thread caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 11, 2018
View reviewed changes
Comment thread caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Sep 11, 2018
View reviewed changes
Comment thread caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

@cpuhrsch @facebook-github-bot
caffe2::StorageImpl use at::DataPtr (pytorch#11282)
ce819ad 
Summary:
See title
Pull Request resolved: pytorch#11282

Reviewed By: ezyang

Differential Revision: D9658503

Pulled By: cpuhrsch

fbshipit-source-id: 0bacd88c95266e7cb7e77488d1ba2f104a0c9f55
zdevito pushed a commit to zdevito/ATen that referenced this pull request Sep 12, 2018
@cpuhrsch @facebook-github-bot
caffe2::StorageImpl use at::DataPtr (#11282)
bb3f501 
Summary:
See title
Pull Request resolved: pytorch/pytorch#11282

Reviewed By: ezyang

Differential Revision: D9658503

Pulled By: cpuhrsch

fbshipit-source-id: 42fa73c979692cb1069c0345744a85d12150745c
petrex pushed a commit to petrex/pytorch that referenced this pull request Sep 12, 2018
Merge branch 'master' into hipGlooIntegration
a0e4176 
* master: (165 commits)
  Aibench for asr decoder
  Explicitly set locale on docs build. (pytorch#11595)
  Documentation for debugging JIT
  Fused weightnorm for ATen (pytorch#10842)
  Move Type, Tensor, TensorMethods to core.
  Add reminder % to the jit
  Fix reloading modules back into python (pytorch#11552)
  Add trigonometry functions to docs/source/onnx.rst
  Add EndToEndHybridModel CUDA tests (pytorch#11544)
  minor formatting error log (pytorch#11528)
  Warn that export+import module always load onto the CPU (pytorch#11485)
  caffe2::StorageImpl use at::DataPtr (pytorch#11282)
  Sync all libnccl soversions, not just libnccl.so.1 (pytorch#11575)
  Document BatchNorm and update default behavior (pytorch#11484)
  Typo fix in randomness.rst (pytorch#11571)
  Move some bmm/baddbmm to ATen (pytorch#11292)
  Make c10d test work on CPU only build (pytorch#11567)
  Clean up some C++ cruftiness in the script lexer.
  Allow setting deletion constant
  Make C10d support CPU only build (pytorch#11513)
  ...
@ezyang ezyang added the merged label Jun 26, 2019
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@cpuhrsch @facebook-github-bot
caffe2::StorageImpl use at::DataPtr (pytorch#11282)
0b9c929 
Summary:
See title
Pull Request resolved: pytorch#11282

Reviewed By: ezyang

Differential Revision: D9658503

Pulled By: cpuhrsch

fbshipit-source-id: 42fa73c979692cb1069c0345744a85d12150745c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

+1 more reviewer

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

caffe2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cpuhrsch @ezyang @facebook-github-bot @pytorchbot