Remove tests from test_jit.py that are now passing#11279
Closed
driazati wants to merge 5 commits intopytorch:masterfrom
driazati:remove_excludes
Closed
Remove tests from test_jit.py that are now passing#11279driazati wants to merge 5 commits intopytorch:masterfrom driazati:remove_excludes
driazati wants to merge 5 commits intopytorch:masterfrom
driazati:remove_excludes
Conversation
Contributor
|
Can we please make mark all skipped tests as expected failures to ensure that the list will always be up to date? |
driazati
commented
Sep 6, 2018
test/test_jit.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
added 4 commits
September 13, 2018 12:14
Summary: A bunch of the tests that were being excluded for tracing/script for failing are now passing, so this PR takes them out of the list Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Contributor
Author
|
There are a couple flakiness issues with the tests that I'm not sure about:
|
colesbury
pushed a commit
to colesbury/pytorch
that referenced
this pull request
Sep 21, 2018
Summary: Spruriously added in pytorch#11261 I had a PR to catch these automatically (pytorch#11279), but it had some issues passing on some CI environments but not others (e.g. for `test_nn_group_norm`), any ideas? Pull Request resolved: pytorch#11916 Differential Revision: D9992065 Pulled By: driazati fbshipit-source-id: 05cfa8ed9af939e8ffd5827847ee7bfe0be799b2
Contributor
If they're flaky we shouldn't mark them as an expected fail and we should probably just skip those for now and file an issue / note |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of the tests that were being excluded for tracing/script for
failing are now passing, so this PR takes them out of the list
@zdevito