Move VariableHooksInterface to ATen/core#11273
Closed
ezyang wants to merge 5 commits intoexport-D9654871from
Closed
Move VariableHooksInterface to ATen/core#11273ezyang wants to merge 5 commits intoexport-D9654871from
ezyang wants to merge 5 commits intoexport-D9654871from
Conversation
Differential Revision: D9656548 Differential Version: 56952265
gchanan
approved these changes
Sep 5, 2018
Contributor
gchanan
left a comment
There was a problem hiding this comment.
I'm kind of surprised this isn't in core/detail.
Differential Revision: D9656548 Differential Version: 57069503
Differential Revision: D9656548 Differential Version: 57070632
Differential Revision: D9656548 Differential Version: 57071082
This was referenced Sep 6, 2018
Differential Revision: D9656548 Differential Version: 57150327
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 7, 2018
Summary: Pull Request resolved: pytorch/pytorch#11273 This one might strike you as a bit surprising, but it's necessary to expose this interface in ATen/core, because we need to be able to get a true Variable type from Variable tensors, and to do that we need to go through the hooks interface. Reviewed By: gchanan Differential Revision: D9656548 fbshipit-source-id: 28bb5aee6ac304e8cd5fa1e4c65452c336647161
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#11273 This one might strike you as a bit surprising, but it's necessary to expose this interface in ATen/core, because we need to be able to get a true Variable type from Variable tensors, and to do that we need to go through the hooks interface. Reviewed By: gchanan Differential Revision: D9656548 fbshipit-source-id: 28bb5aee6ac304e8cd5fa1e4c65452c336647161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #11250 Rename getMaybeVariableType back to getType. 💚
:white_circle: #11270 Move ATen/Registry.h to ATen/core/Registry.h 💚
:black_circle: #11273 Move VariableHooksInterface to ATen/core 💚
:white_circle: #11274 Move the type registry out of Context, into LegacyTypeDispatch. 💛
:white_circle: #11331 Improve LegacyTypeDispatch to handle initialization correctly. 💛
This one might strike you as a bit surprising, but it's necessary
to expose this interface in ATen/core, because we need to be
able to get a true Variable type from Variable tensors, and
to do that we need to go through the hooks interface.
Differential Revision: D9656548