Skip to content

Pin Docker images to main#112692

Closed
huydhn wants to merge 1 commit intopytorch:mainfrom
huydhn:pin-build-images-to-main
Closed

Pin Docker images to main#112692
huydhn wants to merge 1 commit intopytorch:mainfrom
huydhn:pin-build-images-to-main

Conversation

@huydhn
Copy link
Copy Markdown
Contributor

@huydhn huydhn commented Nov 2, 2023

This will help prevent a commit like pytorch/builder@7790132 pushing to release branch from overwrite the Docker images used in main. In addition, the DEFAULT_TAG can be easily updated to 2.1 for example when doing branch cut release. This basically pins the Docker images like #111971

@huydhn huydhn added ciflow/binaries_conda ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR test-config/default labels Nov 2, 2023
@huydhn huydhn requested a review from malfet November 2, 2023 03:02
@huydhn huydhn requested a review from a team as a code owner November 2, 2023 03:02
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 2, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/112692

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit 4090070 with merge base 5a6f801 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Nov 2, 2023

@pytorchbot merge -f "We know that conda builds OOM now"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Nov 7, 2023
This will help prevent a commit like pytorch/builder@7790132 pushing to release branch from overwrite the Docker images used in main.  In addition, the `DEFAULT_TAG` can be easily updated to `2.1` for example when doing branch cut release.  This basically pins the Docker images like pytorch#111971

Pull Request resolved: pytorch#112692
Approved by: https://github.com/malfet
Skylion007 pushed a commit to Skylion007/pytorch that referenced this pull request Nov 14, 2023
This will help prevent a commit like pytorch/builder@7790132 pushing to release branch from overwrite the Docker images used in main.  In addition, the `DEFAULT_TAG` can be easily updated to `2.1` for example when doing branch cut release.  This basically pins the Docker images like pytorch#111971

Pull Request resolved: pytorch#112692
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries_libtorch Trigger binary build and upload jobs for libtorch on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR Merged test-config/default topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants