Move TensorOptions.cpp to the correct place in ATen/core#11244
Closed
Move TensorOptions.cpp to the correct place in ATen/core#11244
Conversation
Differential Revision: D9557315 Differential Version: 56407314
Differential Revision: D9557315 Differential Version: 56413294
Differential Revision: D9557315 Differential Version: 56415719
Differential Revision: D9557315 Differential Version: 56424143
Differential Revision: D9557315 Differential Version: 56437859
Differential Revision: D9561478 Differential Version: 56437861
Differential Revision: D9561478 Differential Version: 56440382
Differential Revision: D9561478 Differential Version: 56440854
Differential Revision: D9562197 Differential Version: 56442349
Differential Revision: D9562312 Differential Version: 56443146
Differential Revision: D9562312 Differential Version: 5644335
Differential Revision: D9562467 Differential Version: 56443875
Differential Revision: D9562467 Differential Version: 56445436
Differential Revision: D9562312 Differential Version: 56445886
Differential Revision: D9557315 Differential Version: 56444203
Differential Revision: D9561478 Differential Version: 56446440
Differential Revision: D9562467 Differential Version: 56447016
Differential Revision: D9562467 Differential Version: 56447216
Differential Revision: D9561478 Differential Version: 56449391
Differential Revision: D9564206 Differential Version: 56452969
Differential Revision: D9562312 Differential Version: 56453321
Differential Revision: D9564516 Differential Version: 56455053
Differential Revision: D9562467 Differential Version: 56473044
Differential Revision: D9562197 Differential Version: 56473286
Differential Revision: D9578398 Differential Version: 56517363
Differential Revision: D9578399 Differential Version: 56517362
Differential Revision: D9578734 Differential Version: 56519039
Differential Revision: D9578734 Differential Version: 56520207
Differential Revision: D9578734 Differential Version: 56526151
Differential Revision: D9581560 Differential Version: 56526196
Differential Revision: D9646190 Differential Version: 56896300
Differential Revision: D9634904 Differential Version: 56940396
Differential Revision: D9646190 Differential Version: 56940395
Differential Revision: D9634904 Differential Version: 56941443
Differential Revision: D9646190 Differential Version: 56941456
Differential Revision: D9634904 Differential Version: 56952261
Differential Revision: D9646190 Differential Version: 56952266
Differential Revision: D9646190 Differential Version: 57069483
Differential Revision: D9646190 Differential Version: 57070541
Differential Revision: D9646190 Differential Version: 57070993
This was referenced Sep 6, 2018
Differential Revision: D9646190 Differential Version: 57146717
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 7, 2018
Summary: This actually ended up being a lot more involved than I thought. The basic problem is that in some of our build environments, thread local state is not supported. The correct way to test if this is the case is using the (undocumented) CAFFE2_FB_LIMITED_MOBILE_CAPABILITY macro. On mobile, OptionGuard is not available, and you have to do everything by hand. There's a static_assert to check if you accidentally use OptionGuard in this case and give you a better error message in this case. Pull Request resolved: pytorch/pytorch#11244 Reviewed By: gchanan Differential Revision: D9646190 fbshipit-source-id: cf4016f79b47705a96ee9b6142eb34c95abb2bd4
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: This actually ended up being a lot more involved than I thought. The basic problem is that in some of our build environments, thread local state is not supported. The correct way to test if this is the case is using the (undocumented) CAFFE2_FB_LIMITED_MOBILE_CAPABILITY macro. On mobile, OptionGuard is not available, and you have to do everything by hand. There's a static_assert to check if you accidentally use OptionGuard in this case and give you a better error message in this case. Pull Request resolved: pytorch#11244 Reviewed By: gchanan Differential Revision: D9646190 fbshipit-source-id: cf4016f79b47705a96ee9b6142eb34c95abb2bd4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #11244 Move TensorOptions.cpp to the correct place in ATen/core 💚
Differential Revision: D9646190