[c10d] Getting rid of USE_C10D for build#11237
Closed
teng-li wants to merge 2 commits intopytorch:masterfrom
Closed
[c10d] Getting rid of USE_C10D for build#11237teng-li wants to merge 2 commits intopytorch:masterfrom
teng-li wants to merge 2 commits intopytorch:masterfrom
Conversation
pietern
approved these changes
Sep 4, 2018
Contributor
pietern
left a comment
There was a problem hiding this comment.
Reminds me that a CUDA free c10d build needs to happen sooner rather than later as well...
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
teng-li has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Will use USE_DISTRIBUTED for both c10d and THD Pull Request resolved: pytorch#11237 Differential Revision: D9647825 Pulled By: teng-li fbshipit-source-id: 06e0ec9b5e2f8f38780fc88718f8499463e9e969
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will use USE_DISTRIBUTED for both c10d and THD