Remove Type constructor from TensorOptions, add Type::options#11189
Closed
Remove Type constructor from TensorOptions, add Type::options#11189
Conversation
Differential Revision: D9557315 Differential Version: 56407314
Differential Revision: D9557315 Differential Version: 56413294
Differential Revision: D9557315 Differential Version: 56415719
Differential Revision: D9557315 Differential Version: 56424143
Differential Revision: D9557315 Differential Version: 56437859
Differential Revision: D9561478 Differential Version: 56437861
Differential Revision: D9561478 Differential Version: 56440382
Differential Revision: D9561478 Differential Version: 56440854
Differential Revision: D9557315 Differential Version: 56444203
Differential Revision: D9561478 Differential Version: 56446440
Differential Revision: D9561478 Differential Version: 56449391
Differential Revision: D9561478 Differential Version: 56541404
Differential Revision: D9561478 Differential Version: 56541860
Differential Revision: D9561478 Differential Version: 56652964
…11181) Differential Revision: D9561478 Differential Version: 56766544
Differential Revision: D9628281 Differential Version: 56766268
Differential Revision: D9561478 Differential Version: 56766790
Differential Revision: D9628281 Differential Version: 56768265
Differential Revision: D9561478 Differential Version: 56768709
Differential Revision: D9628281 Differential Version: 56805602
cpuhrsch
approved these changes
Sep 4, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 4, 2018
Summary: Pull Request resolved: pytorch/pytorch#11189 Replaces it with an operator TensorOptions() method on Type, reestablishing the implicit conversion. I originally wanted to get rid of the implicit conversion entirely, but there were a *lot* of use-sites, so I added it back to avoid a huge codemod. In this patch, I only had to fix sites that used the optional device_index API. Reviewed By: cpuhrsch Differential Revision: D9628281 fbshipit-source-id: 5fe2a68eefb77a3c9bb446f03a94ad723ef90210
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
…h#11189) Summary: Pull Request resolved: pytorch#11189 Replaces it with an operator TensorOptions() method on Type, reestablishing the implicit conversion. I originally wanted to get rid of the implicit conversion entirely, but there were a *lot* of use-sites, so I added it back to avoid a huge codemod. In this patch, I only had to fix sites that used the optional device_index API. Reviewed By: cpuhrsch Differential Revision: D9628281 fbshipit-source-id: 5fe2a68eefb77a3c9bb446f03a94ad723ef90210
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove Type constructor from TensorOptions, add Type::options
Replaces it with an operator TensorOptions() method on
Type, reestablishing the implicit conversion. I originally
wanted to get rid of the implicit conversion entirely, but
there were a lot of use-sites, so I added it back to avoid
a huge codemod. In this patch, I only had to fix sites that
used the optional device_index API.
Differential Revision: D9628281