[build] Support environments with no libprotobuf#11161
Closed
orionr wants to merge 1 commit intopytorch:masterfrom
Closed
[build] Support environments with no libprotobuf#11161orionr wants to merge 1 commit intopytorch:masterfrom
orionr wants to merge 1 commit intopytorch:masterfrom
Conversation
goldsborough
approved these changes
Sep 4, 2018
Contributor
Author
|
And thanks to @goldsborough for all the hard work getting to this elegant fix! It's actually his code. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 5, 2018
Summary: Just pulling this out of pytorch/pytorch#10611 Make sure we can support environments where we don't have libprotobuf installed when we link-local protobuf. cc goldsborough Yangqing Pull Request resolved: pytorch/pytorch#11161 Differential Revision: D9650282 Pulled By: orionr fbshipit-source-id: 447b5e54cd2639973b4b10f58590d1c693a988d4
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Just pulling this out of pytorch#10611 Make sure we can support environments where we don't have libprotobuf installed when we link-local protobuf. cc goldsborough Yangqing Pull Request resolved: pytorch#11161 Differential Revision: D9650282 Pulled By: orionr fbshipit-source-id: 447b5e54cd2639973b4b10f58590d1c693a988d4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just pulling this out of #10611
Make sure we can support environments where we don't have libprotobuf installed when we link-local protobuf.
cc @goldsborough @Yangqing