Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111582
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 530794d with merge base a267d95 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D50460640 |
There was a problem hiding this comment.
Why does this function take as rvalue if all the callbacks are guaranteed to only take const ref? Shouldn't this function also take const-ref then?
Summary: Breaking down pytorch#110307 into smaller pieces to try to land without revert. add most of the code but don't even call the event-creation logic Test Plan: OSS CI and internal tests Differential Revision: D50502961
Summary: Breaking down pytorch#110307 into smaller pieces to try to land without revert. This PR adds some hook functions but does not call them. Test Plan: OSS CI and internal tests pyper test: https://www.internalfb.com/mlhub/pipelines/runs/fblearner/493040128 Differential Revision: D50460640
c4d224a to
530794d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50460640 |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Summary:
Breaking down #110307 into smaller
pieces to try to land without revert.
This PR adds some hook functions but does not call them.
Test Plan: OSS CI and internal tests
Differential Revision: D50460640