Skip to content

return aten::gt to the list of fusable operations, add expected graphs#11150

Closed
ngimel wants to merge 4 commits intopytorch:masterfrom
ngimel:jit_fixes
Closed

return aten::gt to the list of fusable operations, add expected graphs#11150
ngimel wants to merge 4 commits intopytorch:masterfrom
ngimel:jit_fixes

Conversation

@ngimel
Copy link
Collaborator

@ngimel ngimel commented Aug 31, 2018

Fixes one of #11118 issues.

@zou3519 zou3519 added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 31, 2018
apaszke
apaszke reviewed Aug 31, 2018
View reviewed changes
test/test_jit.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

torch/csrc/jit/fusion_compiler.cpp Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@mruberry
Copy link
Collaborator

mruberry commented Sep 4, 2018

I can also rebase just fine, and the split PR already has one merge conflict. Order not important.

apaszke
apaszke approved these changes Sep 7, 2018
View reviewed changes
Copy link
Contributor

@apaszke apaszke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait since @mruberry's patch is going to land soon

@t-vi t-vi mentioned this pull request Sep 12, 2018
Closed
@t-vi
Copy link
Collaborator

t-vi commented Sep 15, 2018

#10981 has been merged. :)

facebook-github-bot
facebook-github-bot reviewed Sep 17, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Sep 20, 2018
@t-vi @facebook-github-bot
Jit fuse clamp (#11574)
068eac2 
Summary:
This patch adds fused forward and backward for clamp to the jit.
This is one item of #11118 . If it's OK, I'd be happy to also add some more of #11118 .

The patch depends on #11150 , which I merged into master as a base. I'll rebase it when that or #10981 is merged.

This is first serious jit patch, thank you, ngimel and the others for their guidance. All errors are my own.
Pull Request resolved: #11574

Differential Revision: D9943090

Pulled By: apaszke

fbshipit-source-id: c40954b8c28c374baab8d3bd89acc9250580dc67
@ngimel ngimel deleted the jit_fixes branch September 23, 2018 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@colesbury colesbury Awaiting requested review from colesbury

@ezyang ezyang Awaiting requested review from ezyang

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

+1 more reviewer

@apaszke apaszke apaszke approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ngimel @mruberry @t-vi @apaszke @facebook-github-bot @ezyang @zou3519