Skip to content

[C10D] address PR feedback for test_hooks.py#111246

Closed
wconstab wants to merge 2 commits intogh/wconstab/207/basefrom
gh/wconstab/207/head
Closed

[C10D] address PR feedback for test_hooks.py#111246
wconstab wants to merge 2 commits intogh/wconstab/207/basefrom
gh/wconstab/207/head

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Oct 13, 2023 •
edited
Loading

@wconstab wconstab mentioned this pull request Oct 13, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111246

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2b32b3c with merge base c151163 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wconstab wconstab mentioned this pull request Oct 13, 2023
Closed
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 13, 2023
wconstab added a commit that referenced this pull request Oct 13, 2023
@wconstab
[C10D] address PR feedback for test_hooks.py
9522f59 
ghstack-source-id: 14628d3
Pull Request resolved: #111246
@wconstab
Copy link
Contributor Author

wconstab commented Oct 16, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 16, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 16, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 16, 2023

The merge job was canceled. If you believe this is a mistake, then you can re trigger it through pytorch-bot.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Dec 15, 2023
@github-actions github-actions bot closed this Jan 14, 2024
@github-actions github-actions bot deleted the gh/wconstab/207/head branch February 19, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@fegin fegin Awaiting requested review from fegin

@fduwjj fduwjj Awaiting requested review from fduwjj

@wz337 wz337 Awaiting requested review from wz337

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request merging Stale topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wconstab @pytorchmergebot @malfet