[Caffe2] Should not use CAFFE2_API when definition is already in header.#11114
Closed
xkszltl wants to merge 1 commit intopytorch:masterfrom
Closed
[Caffe2] Should not use CAFFE2_API when definition is already in header.#11114xkszltl wants to merge 1 commit intopytorch:masterfrom
xkszltl wants to merge 1 commit intopytorch:masterfrom
Conversation
1866bb1 to
f45951d
Compare
Remove or use CAFFE2_EXPORT.
f45951d to
ee1a392
Compare
ezyang
approved these changes
Sep 2, 2018
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
…rch#11114) Summary: Remove or use CAFFE2_EXPORT. Fix pytorch#11108 Pull Request resolved: pytorch#11114 Differential Revision: D9628293 Pulled By: ezyang fbshipit-source-id: dc3bb7dc5bc299e3b6cfd1cdd640f618c206fb5a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove or use CAFFE2_EXPORT.
Fix #11108