Lower trivial differentiable subgraphs#11110
Closed
apaszke wants to merge 2 commits intopytorch:masterfrom
Closed
Conversation
zdevito
approved these changes
Aug 30, 2018
Contributor
zdevito
left a comment
There was a problem hiding this comment.
Can we add a test somehow?
torch/csrc/jit/graph_executor.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
We create differentiable subgraphs in the JIT so that we can apply optimizations which would normally make it impossible to run the code with autograd. However, in many cases we are too eager about this, and the graphs we slice and up being trivial, and not optimizations are actually applied. In this case, it's better to inline them back and make use of specialized autograd functions, instead of our generic graph implementations.
cb5f4d5 to
229bae2
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: zdevito Pull Request resolved: pytorch#11110 Differential Revision: D9616408 Pulled By: apaszke fbshipit-source-id: f1ae77d698bf0ada32f2c1c3f587e46a4f57a867
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zdevito