Rename getType to getVariableTypeFromBaseType / getVariableType#11095
Closed
ezyang wants to merge 2 commits intoexport-D9581560from
Closed
Rename getType to getVariableTypeFromBaseType / getVariableType#11095ezyang wants to merge 2 commits intoexport-D9581560from
ezyang wants to merge 2 commits intoexport-D9581560from
Conversation
Differential Revision: D9583630 Differential Version: 56536211
Differential Revision: D9583630 Differential Version: 56538643
Contributor
|
In combination with 11078 and 11077 it looks like we're getting a lot of getXYZType functions. Is there a single source of documentation for this? I'd be confused about which one to use in what circumstance. |
Contributor
Author
|
Sure, we can get docs on the functions. Note that these are internal functions and not intended to be used externally. |
gchanan
approved these changes
Aug 31, 2018
Contributor
gchanan
left a comment
There was a problem hiding this comment.
This looks good, although I guess I'm not convinced that it's not better to just have a single getType function (scalar type, device type, is_variable) for all of these things.
Contributor
Author
|
I'm going to defer the docs for a later commit so I can keep this stack landing. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 31, 2018
Summary: Pull Request resolved: pytorch/pytorch#11095 We used getType to mean a lot of things. - getVariableTypeFromBaseType: given a base Type (non-Variable type) compute the Variable Type which corresponds to it. - getVariableType: like at::getType, but return the Variable type rather than the plain type. This rename makes it clearer at the use-site what things are what, and will make a subsequent rename of at::getType easier. Reviewed By: gchanan, cpuhrsch Differential Revision: D9583630 fbshipit-source-id: 2667ec98e7607bc466920c7415a8c651fd56dfca
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
…rch#11095) Summary: Pull Request resolved: pytorch#11095 We used getType to mean a lot of things. - getVariableTypeFromBaseType: given a base Type (non-Variable type) compute the Variable Type which corresponds to it. - getVariableType: like at::getType, but return the Variable type rather than the plain type. This rename makes it clearer at the use-site what things are what, and will make a subsequent rename of at::getType easier. Reviewed By: gchanan, cpuhrsch Differential Revision: D9583630 fbshipit-source-id: 2667ec98e7607bc466920c7415a8c651fd56dfca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename getType to getVariableTypeFromBaseType / getVariableType
We used getType to mean a lot of things.
getVariableTypeFromBaseType: given a base Type (non-Variable type)
compute the Variable Type which corresponds to it.
getVariableType: like at::getType, but return the Variable type
rather than the plain type.
This rename makes it clearer at the use-site what things are what,
and will make a subsequent rename of at::getType easier.
Differential Revision: D9583630
Stacked on #11087