Disable -Werror on macOS test build#11090
Conversation
Don't get me wrong, -Werror is great. However, when you have to resubmit your PR 3 times, because -Werror doesn't report half of those errors in a Linux environment, it starts to get really annoying.
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Why? I think it warrants an explanation 😅 |
|
Because I just spent over 2h waiting for 2 CI runs (and it's not the first time I had that problem). Both failed only because of
I'd be very happy to reenable this check, but we need to make sure we can reproduce all the failures locally without having to build PyTorch from scratch on a 4 core laptop. |
|
(Just a debugging communication note: @goldsborough probably hasn't seen the internal discussion about this in OSS CI yet) |
Summary: cc goldsborough Pull Request resolved: pytorch#11090 Reviewed By: soumith Differential Revision: D9582525 Pulled By: apaszke fbshipit-source-id: 5d2c6e930e7b09f0ed5a35fbf4fe36b8845a2580
cc @goldsborough