Rename getTypeRaw to getNonVariableTypeRaw#11078
Closed
ezyang wants to merge 1 commit intoexport-D9578398from
Closed
Rename getTypeRaw to getNonVariableTypeRaw#11078ezyang wants to merge 1 commit intoexport-D9578398from
ezyang wants to merge 1 commit intoexport-D9578398from
Conversation
Differential Revision: D9578399 Differential Version: 56517362
This was referenced Aug 30, 2018
Contributor
|
getNonVariableTypeOpt returns a type here, but now getNonVariableTypeRaw also returns a Type and they appear to accept the same arguments (backend and scalar). What's the difference between these two? Also same comment here: Instead of saying what it is, does it make sense to say what it is (i.e. getTensorTypeRaw)? |
Contributor
Author
|
Basically, the Raw function doesn't initialize CUDA if you grab a CUDA type, where as the Opt and non-Opt functions do. I wrote a comment about this in one of my commits, but I can't find it anymore... |
gchanan
approved these changes
Aug 31, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 31, 2018
Summary: Pull Request resolved: pytorch/pytorch#11078 ``` codemod -d . --extensions cc,cpp,cu,cuh,h getTypeRaw getNonVariableTypeRaw ``` Reviewed By: gchanan, cpuhrsch Differential Revision: D9578399 fbshipit-source-id: 00a86ae8fb00d14116762ce39d15858da9a1671e
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#11078 ``` codemod -d . --extensions cc,cpp,cu,cuh,h getTypeRaw getNonVariableTypeRaw ``` Reviewed By: gchanan, cpuhrsch Differential Revision: D9578399 fbshipit-source-id: 00a86ae8fb00d14116762ce39d15858da9a1671e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename getTypeRaw to getNonVariableTypeRaw
Differential Revision: D9578399
Stacked on #11077