Remove MetaNetDef test case in Predictor#11052
Closed
yic-e wants to merge 1 commit intopytorch:masterfrom
yic-e:export-D9566935
Closed
Remove MetaNetDef test case in Predictor#11052yic-e wants to merge 1 commit intopytorch:masterfrom yic-e:export-D9566935
yic-e wants to merge 1 commit intopytorch:masterfrom
yic-e:export-D9566935
Conversation
Summary: Delete the test case for Predictor with constructing by MetaNetDef since the constructor actually has been deprecated. The broken PR is for construcing predictor from DB instance. Reviewed By: highker Differential Revision: D9566935 fbshipit-source-id: bfde2e5bc128f4c2dccf7f88997f0a49ed62e39b
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#11052 Delete the test case for Predictor with constructing by MetaNetDef since the constructor actually has been deprecated. The broken PR is for construcing predictor from DB instance. Reviewed By: highker Differential Revision: D9566935 fbshipit-source-id: 5511883953a2d3f6eb0a4f1c5518a1bc4b3ffbdc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Delete the test case for Predictor with constructing by MetaNetDef since the constructor
actually has been deprecated. The broken PR is for construcing predictor from DB instance.
Reviewed By: highker
Differential Revision: D9566935