Optimize WeightedSumOp for two inputs#11049
Closed
xiaomengy wants to merge 1 commit intopytorch:masterfrom
Closed
Conversation
1729bf7 to
54ea7e4
Compare
54ea7e4 to
b94a978
Compare
Contributor
Author
|
@pytrochbot retest this please |
Contributor
Author
|
Some benchmark on GPU input_shape = [100, 100, 100, 500], So this diff can reduce about 30% time of WeightedSumOp on training jobs. |
b94a978 to
a693f51
Compare
a693f51 to
4952640
Compare
houseroad
reviewed
Aug 31, 2018
caffe2/operators/utility_ops.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
houseroad
reviewed
Aug 31, 2018
caffe2/utils/math_gpu.cu
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
4952640 to
a881bb3
Compare
a881bb3 to
64c2ba6
Compare
64c2ba6 to
360cf09
Compare
360cf09 to
5467702
Compare
Contributor
Author
|
@pytorchbot retest this please |
5467702 to
ac2e2c6
Compare
Summary: Pull Request resolved: pytorch#11049 Optimize WeightedSumOp for two inputs Reviewed By: houseroad Differential Revision: D9566692 fbshipit-source-id: d14d2b3105947f99a780848f4317acc3fb717572
ac2e2c6 to
c34a647
Compare
Contributor
|
Getting the following error on Linux (CentOS 7 + gcc 7.3.1 + CUDA 9.2.148) after this PR: |
Contributor
|
It is reported for |
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#11049 Optimize WeightedSumOp for two inputs Reviewed By: houseroad Differential Revision: D9566692 fbshipit-source-id: 9aab1f02251d386b6f7d0699ae11eeb2ea2b5b4f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Optimize WeightedSumOp for four inputs (2 weighted inputs), just call one kernel instead of two kernels.
Differential Revision: D9566692