Remove use_count() == 1 in Tensor::Extend#11046
Closed
tullie wants to merge 1 commit intopytorch:masterfrom
tullie:export-D9566323
Closed
Remove use_count() == 1 in Tensor::Extend#11046tullie wants to merge 1 commit intopytorch:masterfrom tullie:export-D9566323
tullie wants to merge 1 commit intopytorch:masterfrom
tullie:export-D9566323
Conversation
Summary: As suggested by jerryzh168, temporary fix for a new constraint that was added D9350686 is to remove this assert. Long term jerryzh168 is going to work out a better way of handling this. Differential Revision: D9566323 fbshipit-source-id: a08d4b320de904305e9c209435e53d094b51e4dd
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#11046 As suggested by jerryzh168, temporary fix for a new constraint that was added D9350686 is to remove this assert. Long term jerryzh168 is going to work out a better way of handling this. Reviewed By: jerryzh168 Differential Revision: D9566323 fbshipit-source-id: e4630c7cbe0cc68a084974ea7048654811fae01f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: As suggested by jerryzh168, temporary fix for a new constraint that was added D9350686 is to remove this assert. Long term jerryzh168 is going to work out a better way of handling this.
Differential Revision: D9566323