[build] Inject GetEmptyStringAlreadyInited once for static proto#11045
Closed
orionr wants to merge 1 commit intopytorch:masterfrom
Closed
[build] Inject GetEmptyStringAlreadyInited once for static proto#11045orionr wants to merge 1 commit intopytorch:masterfrom
orionr wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
Author
|
@pytorchbot retest this please |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mingzhe09088
approved these changes
Aug 30, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 30, 2018
Summary: I've been seeing a lot of warnings about multiple declarations of this. Hopefully this fixes it. cc Yangqing mingzhe09088 ezyang Pull Request resolved: pytorch/pytorch#11045 Reviewed By: mingzhe09088 Differential Revision: D9582756 Pulled By: orionr fbshipit-source-id: 6171485609a2f2f357d6e1c44e26b4ecfcdb4ce6
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: I've been seeing a lot of warnings about multiple declarations of this. Hopefully this fixes it. cc Yangqing mingzhe09088 ezyang Pull Request resolved: pytorch#11045 Reviewed By: mingzhe09088 Differential Revision: D9582756 Pulled By: orionr fbshipit-source-id: 6171485609a2f2f357d6e1c44e26b4ecfcdb4ce6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been seeing a lot of warnings about multiple declarations of this. Hopefully this fixes it.
cc @Yangqing @mingzhe09088 @ezyang