Conversation
|
@pytorchbot retest this please |
58f0f2f to
e5710ed
Compare
50183a6 to
14133dc
Compare
zdevito
left a comment
There was a problem hiding this comment.
The removal pass is unnecessary, but this otherwise looks good.
torch/csrc/jit/passes/erase_detach.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
facebook-github-bot
left a comment
There was a problem hiding this comment.
jamesr66a has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
test/test_jit.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
test/test_jit.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
NB: this also needs to be rebased on top of master, because it uses the legacy tracing API in the test |
977eb89 to
a009163
Compare
facebook-github-bot
left a comment
There was a problem hiding this comment.
jamesr66a is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: This makes it so `detach` and `detach_` are traceable and also adds a pass to erase them before ONNX export Pull Request resolved: pytorch/pytorch#11038 Differential Revision: D9588038 Pulled By: jamesr66a fbshipit-source-id: 263dd3147e24fcb0c716743f37fdb9f84c0015e7
Summary: This makes it so `detach` and `detach_` are traceable and also adds a pass to erase them before ONNX export Pull Request resolved: pytorch#11038 Differential Revision: D9588038 Pulled By: jamesr66a fbshipit-source-id: 263dd3147e24fcb0c716743f37fdb9f84c0015e7
This makes it so
detachanddetach_are traceable and also adds a pass to erase them before ONNX export