Closed
Conversation
Differential Revision: D9563464 Differential Version: 56449129
Differential Revision: D9563464 Differential Version: 56449545
ezyang
approved these changes
Aug 29, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
I only checked the strong tests and not the weak ones.
Differential Revision: D9563464 Differential Version: 56453606
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 30, 2018
Summary: Pull Request resolved: pytorch/pytorch#11026 ezyang fixed a bug with moving or copying an intrusive_ptr into itself. This diff adds test cases for it. Reviewed By: ezyang Differential Revision: D9563464 fbshipit-source-id: 3a3b3f681124730d2500b276c0135c3bba7875ae
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#11026 ezyang fixed a bug with moving or copying an intrusive_ptr into itself. This diff adds test cases for it. Reviewed By: ezyang Differential Revision: D9563464 fbshipit-source-id: 3a3b3f681124730d2500b276c0135c3bba7875ae
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test cases to intrusive_ptr
@ezyang fixed a bug with moving or copying an intrusive_ptr into itself.
This diff adds test cases for it.
Differential Revision: D9563464