[dynamo][guards-log] Add debug msg for nn_module_guards only when log is enabled#110167
[dynamo][guards-log] Add debug msg for nn_module_guards only when log is enabled#110167anijain2305 wants to merge 1 commit intogh/anijain2305/136/basefrom
Conversation
… is enabled [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/110167
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit d8f8895 with merge base d0f82cd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
||
| # debug_msg is only for debugging help and goes to kwargs of guard call, | ||
| # which is ignored. | ||
| self._produce_guard_code(guard, [f'{name}({ref}, debug_msg="{g}")']) |
There was a problem hiding this comment.
Can we make this more symmetric with how regular guard debugging? Specifically, pass the debug message to produce_guard_code, and propagate it to the debugging logic later
There was a problem hiding this comment.
Will look more into this. Let me get this one in to avoid perf regressions if any.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / linux-focal-rocm5.6-py3.8 / test (default, 2, 3, linux.rocm.gpu) Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "unrelated rocm failure" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Stack from ghstack (oldest at bottom):
I did not do any benchmarks, but there could be a small overhead of creating the debug_msg. Adding debug_msg only when guards log is enabled.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng