at::StorageImpl: Rename size_ to numel_ and elementSize() to itemsize()#11011
Closed
cpuhrsch wants to merge 1 commit intopytorch:masterfrom
Closed
at::StorageImpl: Rename size_ to numel_ and elementSize() to itemsize()#11011cpuhrsch wants to merge 1 commit intopytorch:masterfrom
cpuhrsch wants to merge 1 commit intopytorch:masterfrom
Conversation
ezyang
approved these changes
Aug 29, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
You need a more detailed commit message. It should include justification for why the new names are better. (In this case, numel to disambiguate size from bytes, and itemsize to line up our API with Caffe2's)
ezyang
reviewed
Aug 29, 2018
aten/src/ATen/Storage.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Use numel to disambiguate size from bytes and itemsize to line up with caffe2::StorageImpl
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
cpuhrsch has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 30, 2018
Summary: Pull Request resolved: pytorch/pytorch#11011 Reviewed By: ezyang Differential Revision: D9561898 Pulled By: cpuhrsch fbshipit-source-id: 0cf5cdc3e7acd397f7e2d66097856aaad0581147
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#11011 Reviewed By: ezyang Differential Revision: D9561898 Pulled By: cpuhrsch fbshipit-source-id: 0cf5cdc3e7acd397f7e2d66097856aaad0581147
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.