Skip to content

add export import test to TestJitGenerated#10982

Closed
eellison wants to merge 5 commits intopytorch:masterfrom
eellison:generated_tests
Closed

add export import test to TestJitGenerated#10982
eellison wants to merge 5 commits intopytorch:masterfrom
eellison:generated_tests

Conversation

@eellison
Copy link
Contributor

@eellison eellison commented Aug 29, 2018

Checking assertExportImport for all of the generated test jit tests.

@zou3519 zou3519 added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 29, 2018
@zou3519
Copy link
Contributor

zou3519 commented Aug 29, 2018 •
edited
Loading

Some of the tests (looks like only python 2) are failing with

01:21:26 ======================================================================
01:21:26 ERROR: test_norm_keepdim_1_5_dim_neg0 (__main__.TestJitGenerated)
01:21:26 ----------------------------------------------------------------------
01:21:26 Traceback (most recent call last):
01:21:26   File "test_jit.py", line 7097, in do_test
01:21:26     check(name)
01:21:26   File "test_jit.py", line 7070, in check
01:21:26     fn, (self_variable,) + args_variable, kwargs_variable)
01:21:26   File "test_jit.py", line 6753, in check_against_reference
01:21:26     self.assertExportImport(graph, graph_inputs)
01:21:26 TypeError: unbound method assertExportImport() must be called with TestJit instance as first argument (got Graph instance instead)

bug or feature?

@eellison
Copy link
Contributor Author

eellison commented Aug 29, 2018

Ohhh, bug. Will fix that & update

ezyang
ezyang reviewed Aug 29, 2018
View reviewed changes
test/test_jit.py Outdated

This comment was marked as off-topic.

Sign in to view

@eellison
Copy link
Contributor Author

eellison commented Aug 29, 2018

@pytorchbot retest this please

@eellison
Copy link
Contributor Author

eellison commented Aug 30, 2018

@pytorchbot retest this please

facebook-github-bot
facebook-github-bot reviewed Sep 4, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

zdevito
zdevito reviewed Sep 4, 2018
View reviewed changes
Copy link
Contributor

@zdevito zdevito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a way of doing this that doesn't require copy/pasting the test harness. Let me know if the suggestion works.

test/test_jit.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

facebook-github-bot
facebook-github-bot reviewed Sep 7, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zdevito has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@eellison
Copy link
Contributor Author

eellison commented Sep 7, 2018

@pytorchbot retest this please

1 similar comment
@eellison
Copy link
Contributor Author

eellison commented Sep 10, 2018

@pytorchbot retest this please

PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Sep 11, 2018
@PenghuiCheng
add export import test to TestJitGenerated (pytorch#10982)
c9abeec 
Summary:
Checking assertExportImport for all of the generated test jit tests.
Pull Request resolved: pytorch#10982

Differential Revision: D9636935

Pulled By: eellison

fbshipit-source-id: f3f1ce77d454848098f2ac7e0fa18bf8564890be
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang left review comments

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@zdevito zdevito zdevito approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

Assignees

No one assigned

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@eellison @zou3519 @ezyang @zdevito @facebook-github-bot