[ONNX] allow no-alpha add/sub in onnx symbolic#10972
Closed
wanchaol wants to merge 3 commits intopytorch:masterfrom
Closed
[ONNX] allow no-alpha add/sub in onnx symbolic#10972wanchaol wants to merge 3 commits intopytorch:masterfrom
wanchaol wants to merge 3 commits intopytorch:masterfrom
Conversation
houseroad
reviewed
Aug 28, 2018
torch/onnx/symbolic.py
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
b788207 to
a8bef01
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
wanchaol has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
wanchaol has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jamesr66a
approved these changes
Sep 17, 2018
Collaborator
jamesr66a
left a comment
There was a problem hiding this comment.
Cool, let's do it. So long as this rebases cleanly I think this is OK
63be67a to
e5efebd
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
wanchaol has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
Author
|
@jamesr66a this is causing some internal tests failures, I will investigate it. |
jamesr66a
pushed a commit
to jamesr66a/translate-1
that referenced
this pull request
Sep 18, 2018
Summary: The PR fixes #10873 The context is aten::add and aten::sub ST overloads don't have alpha, so onnx symbolic does not match. Pull Request resolved: pytorch/pytorch#10972 Differential Revision: D9724224 fbshipit-source-id: 902a2a6a04452a8ce428ecac7cd7e912d6787178
jamesr66a
pushed a commit
to jamesr66a/translate-1
that referenced
this pull request
Sep 18, 2018
Summary: The PR fixes #10873 The context is aten::add and aten::sub ST overloads don't have alpha, so onnx symbolic does not match. Pull Request resolved: pytorch/pytorch#10972 Differential Revision: D9724224 fbshipit-source-id: 42326b91a57490e070db5ba4c9a8e9e75fc0b364
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes #10873
The context is aten::add and aten::sub ST overloads don't have alpha, so onnx symbolic does not match.