[pytorch][PR] Generate Type::registerCPU as we do register_cuda_types.#10947
Closed
gchanan wants to merge 2 commits intopytorch:masterfrom
Closed
[pytorch][PR] Generate Type::registerCPU as we do register_cuda_types.#10947gchanan wants to merge 2 commits intopytorch:masterfrom
gchanan wants to merge 2 commits intopytorch:masterfrom
Conversation
The goal here is to separate out the base Type into core; as it was done previously we need all derived Types to be defined when we compile the base Type.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Aug 28, 2018
Contributor
ezyang
left a comment
There was a problem hiding this comment.
Nit: Put RegisterCPU.h in detail, rather than top level.
Contributor
Author
|
I think RegisterCPU should match RegisterCUDA; we should move both to detail in a later commit. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 29, 2018
Summary: The goal here is to separate out the base Type into core; as it was done previously we need all derived Types to be defined when we compile the base Type. Pull Request resolved: pytorch/pytorch#10947 Reviewed By: gchanan Differential Revision: D9540025 Pulled By: ezyang fbshipit-source-id: 49f0b5acb3c378348ef3a55780abb73e4ae27edd
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: The goal here is to separate out the base Type into core; as it was done previously we need all derived Types to be defined when we compile the base Type. Pull Request resolved: pytorch#10947 Reviewed By: gchanan Differential Revision: D9540025 Pulled By: ezyang fbshipit-source-id: 49f0b5acb3c378348ef3a55780abb73e4ae27edd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[pytorch][PR] Generate Type::registerCPU as we do register_cuda_types.
The goal here is to separate out the base Type into core; as it was done previously we need all derived Types to be defined when we compile the base Type.
GitHub Author: Gregory Chanan gchanan@fb.com
Differential Revision: D9540025