[c10d] PT1 Distributed Release MileStone No.1 - Completed Distributed Package and CI tests#10871
Closed
teng-li wants to merge 4 commits intopytorch:masterfrom
Closed
[c10d] PT1 Distributed Release MileStone No.1 - Completed Distributed Package and CI tests#10871teng-li wants to merge 4 commits intopytorch:masterfrom
teng-li wants to merge 4 commits intopytorch:masterfrom
Conversation
72eed12 to
b6123c1
Compare
b2bd6eb to
a51cdca
Compare
2b60fbf to
ed9a2e6
Compare
pietern
approved these changes
Aug 27, 2018
Contributor
pietern
left a comment
There was a problem hiding this comment.
LGTM, aside from minor snafu. There is also the illegal memory access error for the NCCL tests.
torch/lib/c10d/ProcessGroupMPI.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
86e12c1 to
2080b18
Compare
Contributor
|
Assuming this will turn green when #10932 is merged? |
Contributor
Author
|
@pietern One more thing to do, is to fix the c10d ddp test, and hopefully it will be green |
2080b18 to
7334a63
Compare
7334a63 to
101af10
Compare
Contributor
Author
|
@pytorchbot retest this please |
3f76d1f to
1e7fe5e
Compare
d2a2877 to
da05147
Compare
da05147 to
a89aa1d
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
teng-li has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
teng-li has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
…e and CI tests (pytorch#10871) Summary: The PR includes: (1) torch.distributed.c10d, which now includes the complete backward compatible frontend API for `torch.distributed` (2) `env://` init method functionality (3) Minor change to `test_distributed.py`, which is now a test for `torch.distributed.c10d`. (4) The old `test_distributed.py' is now moved to `test_distributed_thd` (5) Miscellaneous bug fixes. (6) DDP CPU test is removed since c10d doesn't have this support yet, but this is a very easy test after moving DDP CPU's dependency to torch.distributed.c10d. (7) CI config to test MPI, NCCL, and Gloo backend of c10d **Now all the distributed test including c10d DDP can pass with the c10d frontend API** TODO: (in a separate PR) MPI subgroup support, once this is added, CI group test will be enabled. Pull Request resolved: pytorch#10871 Differential Revision: D9554514 Pulled By: teng-li fbshipit-source-id: fb686ad42258526c8b4372148e82969fac4f42dd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR includes:
(1) torch.distributed.c10d, which now includes the complete backward compatible frontend API for
torch.distributed(2)
env://init method functionality(3) Minor change to
test_distributed.py, which is now a test fortorch.distributed.c10d.(4) The old
test_distributed.py' is now moved totest_distributed_thd`(5) Miscellaneous bug fixes.
(6) DDP CPU test is removed since c10d doesn't have this support yet, but this is a very easy test after moving DDP CPU's dependency to torch.distributed.c10d.
(7) CI config to test MPI, NCCL, and Gloo backend of c10d
Now all the distributed test including c10d DDP can pass with the c10d frontend API
TODO: (in a separate PR)
MPI subgroup support, once this is added, CI group test will be enabled.