Skip to content

[ONNX] Enable fusing aten::expand on GT, LT, EQ#10845

Closed
houseroad wants to merge 8 commits intopytorch:masterfrom
houseroad:enable_more_onnx_peephole
Closed

[ONNX] Enable fusing aten::expand on GT, LT, EQ#10845
houseroad wants to merge 8 commits intopytorch:masterfrom
houseroad:enable_more_onnx_peephole

Conversation

@houseroad
Copy link
Member

@houseroad houseroad commented Aug 24, 2018

GT, LT, EQ all support numpy broadcasting, just enable the fusion.

facebook-github-bot
facebook-github-bot reviewed Aug 24, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Aug 24, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ezyang
ezyang reviewed Aug 24, 2018
View reviewed changes
torch/csrc/jit/passes/onnx/peephole.cpp Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Aug 24, 2018
View reviewed changes
torch/csrc/jit/passes/onnx/peephole.cpp Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Aug 24, 2018
View reviewed changes
torch/csrc/jit/passes/onnx/peephole.cpp Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang reviewed Aug 24, 2018
View reviewed changes
torch/csrc/jit/passes/onnx/peephole.cpp Outdated

This comment was marked as off-topic.

Sign in to view

ezyang
ezyang approved these changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with comments.

MisterTea
MisterTea reviewed Aug 27, 2018
View reviewed changes
test/onnx/test_operators.py Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@zou3519 zou3519 added the module: onnx Related to torch.onnx label Aug 28, 2018
@houseroad houseroad force-pushed the enable_more_onnx_peephole branch from 3b1074a to fcc596a Compare August 28, 2018 19:32
facebook-github-bot
facebook-github-bot reviewed Aug 28, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Aug 29, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@houseroad houseroad force-pushed the enable_more_onnx_peephole branch from 7d51153 to d8b2be4 Compare August 29, 2018 04:27
facebook-github-bot
facebook-github-bot reviewed Aug 29, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Aug 29, 2018
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Sep 11, 2018
@houseroad @PenghuiCheng
Enable fusing aten::expand on GT, LT, EQ (pytorch#10845)
1950f3c 
Summary:
GT, LT, EQ all support numpy broadcasting, just enable the fusion.
Pull Request resolved: pytorch#10845

Reviewed By: bddppq

Differential Revision: D9494089

Pulled By: houseroad

fbshipit-source-id: 7c65ca06c54dbd476ac7d07b47a413faaed3dd5e
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ezyang ezyang ezyang approved these changes

@anderspapitto anderspapitto Awaiting requested review from anderspapitto

@apaszke apaszke Awaiting requested review from apaszke

@bddppq bddppq Awaiting requested review from bddppq

@colesbury colesbury Awaiting requested review from colesbury

@dzhulgakov dzhulgakov Awaiting requested review from dzhulgakov

@gchanan gchanan Awaiting requested review from gchanan

@jamesr66a jamesr66a Awaiting requested review from jamesr66a

@smessmer smessmer Awaiting requested review from smessmer

@soumith soumith Awaiting requested review from soumith

@Yangqing Yangqing Awaiting requested review from Yangqing

@zdevito zdevito Awaiting requested review from zdevito

+1 more reviewer

@MisterTea MisterTea MisterTea left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: onnx Related to torch.onnx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@houseroad @ezyang @MisterTea @facebook-github-bot @zou3519