[Caffe2] Add MIOPEN recurrent operator#10840
[Caffe2] Add MIOPEN recurrent operator#10840rohithkrn wants to merge 7 commits intopytorch:masterfrom rohithkrn:miopen_rnn_integration
Conversation
bddppq
left a comment
There was a problem hiding this comment.
Overall looks good. Thanks!
| template <typename T> | ||
| TensorDescriptors<T>::TensorDescriptors( | ||
| size_t n, | ||
| std::vector<int>& dim, |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
caffe2/python/hypothesis_test.py
Outdated
|
|
||
| W = np.random.rand(total_sz).astype(np.float32) | ||
| self.ws.create_blob("WEIGHT").feed(W, device_option=hu.gpu_do) | ||
| self.ws.create_blob("WEIGHT").feed(W, device_option=hu.hip_do if workspace.has_hip_support |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@rohithkrn @petrex Looks like miopen RNN doesn't support dropout? |
|
No Miopen doesn’t support dropout.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: bddppq <notifications@github.com>
Sent: Saturday, August 25, 2018 11:21 PM
To: pytorch/pytorch
Cc: Yeh, Peter; Mention
Subject: Re: [pytorch/pytorch] [Caffe2] Add MIOPEN recurrent operator (#10840)
@rohithkrn<https://github.com/rohithkrn> @petrex<https://github.com/petrex> Looks like miopen RNN doesn't support dropout?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#10840 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAqt_9q0Ku4EomNOb9jqsc5tuS618wZ1ks5uUj5cgaJpZM4WKhSR>.
|
| rnnDesc_, | ||
| seqLength, | ||
| xDesc_->descs(), | ||
| InputData(INPUT), //.template data<T>(),./install.sh -icd |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
@petrex Is there any plan to add support to dropout in MIOpen? |
caffe2/python/hypothesis_test.py
Outdated
| for input_idx in input_idxs: | ||
| self.assertGradientChecks( | ||
| hu.gpu_do, op, inputs, input_idx, [0], | ||
| device_option, inputs, input_idx, [0], |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
facebook-github-bot
left a comment
There was a problem hiding this comment.
bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: The goal of this PR is to enable miopen engine(for hip devices) for recurrent operator and also enable corresponding unit test. bddppq petrex Pull Request resolved: pytorch#10840 Differential Revision: D9518980 Pulled By: bddppq fbshipit-source-id: 214661e79a47c5dc6b712ef0fba986bd99db051f
The goal of this PR is to enable miopen engine(for hip devices) for recurrent operator and also enable corresponding unit test.
@bddppq @petrex