Use ctypes to serialize raw content for tensors.#108287
Use ctypes to serialize raw content for tensors.#108287
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108287
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d93c77d with merge base b535ed2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
test/inductor/test_aot_inductor.py
Outdated
| actual = AOTInductorModelRunner.run(model, example_inputs, expected) | ||
| self.assertTrue(same(actual, expected)) | ||
|
|
||
| @requires_cpp_extension() |
There was a problem hiding this comment.
I recently changed this file. You will need to remove this line.
|
cc @Chillee as this week's oncall. Last nightly run has shown timeout because of this issue, https://github.com/pytorch/pytorch/actions/runs/6021619982/job/16335510610. I prefer to merge this PR as a forward fix. |
Summary: There's a deadlock in current storage's implementation if the size of tensor is too large. Use ctypes to do serialization. Test Plan: python benchmarks/dynamo/huggingface.py --bfloat16 --accuracy --inference --device cuda --export-aot-inductor --only MT5ForConditionalGeneration Reviewers: Subscribers: Tasks: Tags:
a415f3e to
d93c77d
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "Internal test failure from #107718. Revert this one first and then revert 107718." -c nosignal |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@muchulee8 your PR has been successfully reverted. |
This reverts commit 43f28be. Reverted #108287 on behalf of https://github.com/desertfire due to Internal test failure from #107718. Revert this one first and then revert 107718. ([comment](#108287 (comment)))
|
@desertfire unland internal diff, it should auto revert PR, doing it now... |
Summary:
There's a deadlock in current storage's implementation if the size of tensor is too large. Use ctypes to do serialization.
Test Plan:
python benchmarks/dynamo/huggingface.py --bfloat16 --accuracy --inference --device cuda --export-aot-inductor --only MT5ForConditionalGeneration
Reviewers:
Subscribers:
Tasks:
Tags:
Fixes #ISSUE_NUMBER
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @ngimel @yf225 @chenyang78 @kadeng @aakhundov