Create global constant for string literal 'blob_names'#10827
Closed
enosair wants to merge 1 commit intopytorch:masterfrom
Closed
Create global constant for string literal 'blob_names'#10827enosair wants to merge 1 commit intopytorch:masterfrom
enosair wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
Author
|
@jerryzh168 could you review this? The failed building is irrelevant. |
Contributor
|
@enosair you can land the diff in phabricator and this one will be merged. no need for stamp in GH. |
Summary: Pull Request resolved: pytorch#10827 Reviewed By: boryiingsu Differential Revision: D9484567 fbshipit-source-id: 9dd645b9a3141a42b83bc2350bacaf2c9830134b
1754647 to
b2729a2
Compare
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#10827 Reviewed By: boryiingsu Differential Revision: D9484567 fbshipit-source-id: 275eddc9406b5f427d72c0ab9b0da481b5e59ece
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed By: boryiingsu
Differential Revision: D9484567