Closed
Conversation
5248956 to
e0f28bc
Compare
e0f28bc to
46bc4be
Compare
46bc4be to
d6338ac
Compare
d6338ac to
3170b7b
Compare
3170b7b to
4f5707d
Compare
4f5707d to
f3420b8
Compare
f3420b8 to
3673bd1
Compare
Contributor
Author
|
@pytorchbot retest this please |
3673bd1 to
cec9579
Compare
cec9579 to
f6046d6
Compare
Summary: Pull Request resolved: pytorch#10826 Add strides, and make sure the strides are consistent with sizes, and is_contiguous, for all the Caffe2 functions. is_contiguous means strides_[dim-1] = 1 and strides_[i] = strides_[i+1] * max(size_[i+1], 1); Reviewed By: ezyang Differential Revision: D9354480 fbshipit-source-id: 9a07544b7427be11c83ecaccb827ffb14ac818cc
f6046d6 to
506d06e
Compare
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#10826 Add strides, and make sure the strides are consistent with sizes, and is_contiguous, for all the Caffe2 functions. is_contiguous means strides_[dim-1] = 1 and strides_[i] = strides_[i+1] * max(size_[i+1], 1); Reviewed By: ezyang Differential Revision: D9354480 fbshipit-source-id: 3643871b70f1111b7ffdd9fdd9fe9bec82635963
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Add strides, and make sure the strides are consistent with sizes, and is_contiguous, for all the Caffe2 functions.
Differential Revision: D9354480