Closed
Conversation
The schema_ field is a private and internal cache for nodes, and no methods meant to manipulate it should be publicly visible. This call wasn't even necessary at its call site, since removeInput will reset the schema by itself.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
approved these changes
Aug 24, 2018
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: The schema_ field is a private and internal cache for nodes, and no methods meant to manipulate it should be publicly visible. This call wasn't even necessary at its call site, since removeInput will reset the schema by itself. zdevito jamesr66a Pull Request resolved: pytorch#10822 Reviewed By: zdevito Differential Revision: D9498683 Pulled By: apaszke fbshipit-source-id: 42e1743e3737cb7d81f88e556204487d328c0e47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schema_ field is a private and internal cache for nodes, and no
methods meant to manipulate it should be publicly visible. This call
wasn't even necessary at its call site, since removeInput will reset the
schema by itself.
@zdevito @jamesr66a