proper sharing in ShareExternalPointer#10804

Closed

jerryzh168 wants to merge 1 commit intopytorch:masterfrom

jerryzh168:export-D9350686

Contributor

jerryzh168 commented Aug 23, 2018

Summary:
Make ShareData and ShareExternalPointer to create new storage when the old one is used by multiple tensors.
When we need to modify the field of storage, we'll create a new storage instead.

Differential Revision: D9350686

ezyang reviewed

View reviewed changes

caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/core/tensor.h Outdated

This comment was marked as off-topic.

Sign in to view

ezyang reviewed

View reviewed changes

caffe2/core/storage.h Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

jerryzh168 force-pushed the export-D9350686 branch from 402382a to dae98dd Compare

August 23, 2018 17:47

jerryzh168 force-pushed the export-D9350686 branch from dae98dd to 216b5dd Compare

August 23, 2018 18:36

jerryzh168 force-pushed the export-D9350686 branch from 216b5dd to ee02faa Compare

August 23, 2018 19:18

jerryzh168 force-pushed the export-D9350686 branch from ee02faa to 2f0f84a Compare

August 23, 2018 23:42

jerryzh168 force-pushed the export-D9350686 branch from 2f0f84a to 77fb147 Compare

August 24, 2018 17:26

jerryzh168 force-pushed the export-D9350686 branch from 77fb147 to dbf72ae Compare

August 24, 2018 17:37

jerryzh168 force-pushed the export-D9350686 branch from dbf72ae to 7c9b4ab Compare

August 25, 2018 00:00


          proper sharing in ShareExternalPointer (pytorch#10804)

1541ab0

Summary:
Pull Request resolved: pytorch#10804

Make ShareData and ShareExternalPointer to create new storage when the old one is used by multiple tensors.
When we need to modify the field of storage, we'll create a new storage instead.

Differential Revision: D9350686

fbshipit-source-id: 86445136a22cadedee5e3ebe56073e7d3177dc66

jerryzh168 force-pushed the export-D9350686 branch from 7c9b4ab to 1541ab0 Compare

August 27, 2018 22:06

fmassa added the caffe2 label

facebook-github-bot closed this in

7de830b

PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request


          proper sharing in ShareExternalPointer (pytorch#10804)

4a4d8f6

Summary:
Pull Request resolved: pytorch#10804

Make ShareData and ShareExternalPointer to create new storage when the old one is used by multiple tensors.
When we need to modify the field of storage, we'll create a new storage instead.

Reviewed By: ezyang

Differential Revision: D9350686

fbshipit-source-id: 68d2b6b886b0367b0fc4fabfd55b9a480e7388ca

ezyang added the merged label

amjames mentioned this pull request

Update triton pin to move past bugs affecting sparse kernels #109562

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels