[unified build] Default hidden visibility#10752
Closed
orionr wants to merge 16 commits intopytorch:masterfrom
Closed
[unified build] Default hidden visibility#10752orionr wants to merge 16 commits intopytorch:masterfrom
orionr wants to merge 16 commits intopytorch:masterfrom
Conversation
c7f163c to
5156556
Compare
bac7aaf to
97717f1
Compare
c1b3275 to
53dba2b
Compare
ef8ca2f to
26ebdd5
Compare
26ebdd5 to
dafe616
Compare
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
reviewed
Aug 28, 2018
|
|
||
| // TODO: Merge the *_API macros. | ||
| #define AT_API AT_CORE_API | ||
| #define AT_EXPORT AT_CORE_EXPORT |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Aug 28, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 29, 2018
Summary: Flipping to hidden visibility one more time. Let's see what fails. cc mingzhe09088 pjh5 Yangqing Pull Request resolved: pytorch/pytorch#10752 Reviewed By: ezyang Differential Revision: D9526343 Pulled By: orionr fbshipit-source-id: c0e9c29270e95e1b2e21c598095f720c199e1e52
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Flipping to hidden visibility one more time. Let's see what fails. cc mingzhe09088 pjh5 Yangqing Pull Request resolved: pytorch#10752 Reviewed By: ezyang Differential Revision: D9526343 Pulled By: orionr fbshipit-source-id: c0e9c29270e95e1b2e21c598095f720c199e1e52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flipping to hidden visibility one more time. Let's see what fails.
cc @mingzhe09088 @pjh5 @Yangqing