Skip to content

Move Backend, Layout, ATenGeneral, Deprecated, Generator to ATen/core.#10740

Closed
gchanan wants to merge 4 commits intopytorch:masterfrom
gchanan:aten_core3
Closed

Move Backend, Layout, ATenGeneral, Deprecated, Generator to ATen/core.#10740
gchanan wants to merge 4 commits intopytorch:masterfrom
gchanan:aten_core3

Conversation

@gchanan
Copy link
Contributor

@gchanan gchanan commented Aug 21, 2018

I included "legacy" includes in the old spots for Backend, Generator, Layout; it seemed unlikely that the other ones had direct user includes.

This is another step on the path to move Type/Tensor to ATen/core.

I included "legacy" includes in the old spots for Backend, Generator, Layout; it seemed unlikely that the other ones had
direct user includes.

This is another step on the path to move Type/Tensor to ATen/core.
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

constexpr DeviceType kCPU = DeviceType::CPU;
constexpr DeviceType kCUDA = DeviceType::CUDA;

static inline const char* toString(Backend b) {

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.


namespace at {

struct AT_API Generator {

This comment was marked as off-topic.

#include <iostream>

namespace at {
enum class Layout { Strided, Sparse };

This comment was marked as off-topic.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gchanan is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gchanan is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

ezyang pushed a commit to ezyang/pytorch that referenced this pull request Aug 22, 2018
pytorch#10740)

Summary:
I included "legacy" includes in the old spots for Backend, Generator, Layout; it seemed unlikely that the other ones had direct user includes.

This is another step on the path to move Type/Tensor to ATen/core.
Pull Request resolved: pytorch#10740

Reviewed By: ezyang

Differential Revision: D9435888

Pulled By: ezyang

fbshipit-source-id: efe0034e6145834fa5c2d58cbff669e9d20fbe7c
zdevito pushed a commit to zdevito/ATen that referenced this pull request Aug 22, 2018
…. (#10740)

Summary:
I included "legacy" includes in the old spots for Backend, Generator, Layout; it seemed unlikely that the other ones had direct user includes.

This is another step on the path to move Type/Tensor to ATen/core.
Pull Request resolved: pytorch/pytorch#10740

Reviewed By: ezyang

Differential Revision: D9435888

Pulled By: gchanan

fbshipit-source-id: 89f4f0f445d4498a059d3a79069ba641b22bbcac
PenghuiCheng pushed a commit to PenghuiCheng/pytorch that referenced this pull request Sep 11, 2018
pytorch#10740)

Summary:
I included "legacy" includes in the old spots for Backend, Generator, Layout; it seemed unlikely that the other ones had direct user includes.

This is another step on the path to move Type/Tensor to ATen/core.
Pull Request resolved: pytorch#10740

Reviewed By: ezyang

Differential Revision: D9435888

Pulled By: gchanan

fbshipit-source-id: 89f4f0f445d4498a059d3a79069ba641b22bbcac
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants