[pytorch][export] Move is_param and get_param out of exir and into export#107264

Closed

JacobSzwejbka wants to merge 1 commit intopytorch:mainfrom

JacobSzwejbka:export-D48361384

Contributor

JacobSzwejbka commented Aug 15, 2023

Summary: These doesn't feel edge specific so moving out of exir.

Test Plan: ci

Differential Revision: D48361384

pytorch-bot bot commented Aug 15, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107264

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ 1 Unrelated Failure

As of commit c4c6ae6 with merge base 28be2c6 ():

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

linux-focal-rocm5.6-py3.8 / test (default, 1, 3, linux.rocm.gpu, unstable) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions bot added the module: export label

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Aug 15, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

1 similar comment

Contributor

facebook-github-bot commented Aug 16, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

JacobSzwejbka force-pushed the export-D48361384 branch from 37f131b to 929ade7 Compare

August 16, 2023 19:47

Contributor

facebook-github-bot commented Aug 16, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

JacobSzwejbka force-pushed the export-D48361384 branch from 929ade7 to 140365b Compare

August 16, 2023 19:53

Contributor

facebook-github-bot commented Aug 16, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

JacobSzwejbka force-pushed the export-D48361384 branch from 140365b to 18aff45 Compare

August 16, 2023 20:20

Contributor

facebook-github-bot commented Aug 16, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

JacobSzwejbka force-pushed the export-D48361384 branch from 18aff45 to 3731ad5 Compare

August 16, 2023 20:27

angelayi approved these changes

View reviewed changes

Contributor

angelayi left a comment

bump on lintrunner failure

Contributor

facebook-github-bot commented Aug 17, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

JacobSzwejbka force-pushed the export-D48361384 branch from 3731ad5 to da04bde Compare

August 17, 2023 17:17

Contributor

facebook-github-bot commented Aug 17, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

JacobSzwejbka force-pushed the export-D48361384 branch from da04bde to 149c1b6 Compare

August 17, 2023 18:59

Contributor

facebook-github-bot commented Aug 17, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

JacobSzwejbka force-pushed the export-D48361384 branch from 149c1b6 to a520ea7 Compare

August 17, 2023 19:11

Contributor

facebook-github-bot commented Aug 17, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

JacobSzwejbka force-pushed the export-D48361384 branch from a520ea7 to db43cb7 Compare

August 17, 2023 19:32

Contributor

facebook-github-bot commented Aug 17, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

JacobSzwejbka force-pushed the export-D48361384 branch from db43cb7 to c706016 Compare

August 17, 2023 19:38

Contributor

facebook-github-bot commented Aug 17, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

JacobSzwejbka force-pushed the export-D48361384 branch from c706016 to d709a3f Compare

August 17, 2023 19:58


          [pytorch][export] Move is_param and get_param out of exir and into ex…

c4c6ae6

…port (pytorch#107264)

Summary:
Pull Request resolved: pytorch#107264

X-link: pytorch/executorch#67

These doesn't feel edge specific so moving out of exir.

Test Plan: ci

Reviewed By: tugsbayasgalan

Differential Revision: D48361384

fbshipit-source-id: f6476234c16d69ca57e6c30a3e568d08ad5f8062

Contributor

facebook-github-bot commented Aug 18, 2023

This pull request was exported from Phabricator. Differential Revision: D48361384

JacobSzwejbka force-pushed the export-D48361384 branch from d709a3f to c4c6ae6 Compare

August 18, 2023 21:34

JacobSzwejbka added the topic: not user facing label

Contributor

facebook-github-bot commented Aug 22, 2023

@JacobSzwejbka has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Contributor Author

JacobSzwejbka commented Aug 22, 2023

@pytorchbot merge

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Aug 22, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added Merged and removed merging labels

pytorchmergebot closed this in

c14f4d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged topic: not user facing