Adding ATEN_NO_TEST option to root level cmake for propogation to aten#10708
Closed
pjh5 wants to merge 1 commit intopytorch:masterfrom
Closed
Adding ATEN_NO_TEST option to root level cmake for propogation to aten#10708pjh5 wants to merge 1 commit intopytorch:masterfrom
pjh5 wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
pjh5 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
Cancelled most tests b/c the change is so small. Testing one linux |
soumith
approved these changes
Aug 20, 2018
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#10708 Reviewed By: ml7 Differential Revision: D9410916 Pulled By: pjh5 fbshipit-source-id: b216a9ff7be23ff8754f2fe0b8197b5d006aa08d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to propogate this option through the root level CMakeLIsts.txt to aten/CMakeLists.txt