Create fastpath backend context manager, similar to SDPA kernel backend manager#107014

Closed

mikekgfb wants to merge 1 commit intopytorch:mainfrom

mikekgfb:export-D48256968

Contributor

mikekgfb commented Aug 11, 2023 •

edited

Loading

Summary: Create fastpath backend context manager, similar to SDPA kernel backend manager. This allows us control over reproducibility by giving us control over the backend/kernel that will be selected

PRs like #106824 demonstrate the need for controlling what kernels are used in various situations, this gives users a general solution to the problem.

Test Plan: sandcastle, github

Differential Revision: D48256968

mikekgfb requested review from H-Huang, albanD, awgu, fduwjj, fegin, jbschlosser, kwen2501, mikaylagawarecki, mrshenli, rohan-varma, wanchaol and zhaojuanmao as code owners

August 11, 2023 05:30

pytorch-bot bot added the release notes: distributed (fsdp) label

pytorch-bot bot commented Aug 11, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107014

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 22 New Failures, 1 Unrelated Failure

As of commit 8b3d1ad:

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

linux-bionic-py3.8-clang9 / test (dynamo, 2, 2, linux.2xlarge, unstable) (gh)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb requested a review from drisspg

August 11, 2023 05:52

Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb force-pushed the export-D48256968 branch from 2e695dd to 3f9de27 Compare

August 11, 2023 06:17

Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb force-pushed the export-D48256968 branch from 3f9de27 to 6f8a3a0 Compare

August 11, 2023 06:23

mikekgfb mentioned this pull request

Enabling Transformer fast path for not batch_first (MHA, TE, TEL) #106668

Closed

Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb force-pushed the export-D48256968 branch from 6f8a3a0 to 851a06b Compare

August 11, 2023 06:29

Contributor

facebook-github-bot commented Aug 11, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb force-pushed the export-D48256968 branch from 851a06b to 2777b09 Compare

August 11, 2023 06:35

mikekgfb force-pushed the export-D48256968 branch from bce85c1 to a8527db Compare

August 11, 2023 08:31

Contributor

vadimkantorov commented Aug 11, 2023 •

edited

Loading

A bit related:

[proposal] Way to export/display the convolution algorithm found with cudnn.benchmark = True + allow to override cudnn algo choice with conv/matmul module/function algo/hint arguments #52439

albanD removed their request for review

August 11, 2023 15:29

Contributor

facebook-github-bot commented Aug 12, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb force-pushed the export-D48256968 branch from a8527db to 5de60ae Compare

August 12, 2023 22:27

Contributor

facebook-github-bot commented Aug 12, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb force-pushed the export-D48256968 branch from 5de60ae to 66c3601 Compare

August 12, 2023 22:34

mikekgfb mentioned this pull request

[pytorch] Disable fast path in MultiheadAttention in Export #106824

Closed

Contributor

facebook-github-bot commented Aug 12, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb force-pushed the export-D48256968 branch from 66c3601 to 6666c25 Compare

August 12, 2023 22:46

Contributor

facebook-github-bot commented Aug 12, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb force-pushed the export-D48256968 branch from 6666c25 to f6e88c3 Compare

August 12, 2023 22:51

Contributor

facebook-github-bot commented Aug 12, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb force-pushed the export-D48256968 branch from f6e88c3 to d58d1b0 Compare

August 12, 2023 23:46

Contributor

facebook-github-bot commented Aug 13, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb force-pushed the export-D48256968 branch from d58d1b0 to c0b52a0 Compare

August 13, 2023 01:33

mikekgfb pushed a commit to mikekgfb/TestSlide that referenced this pull request


          Create fastpath backend context manager, similar to SDPA kernel backe…

18867b0

…nd manager

Summary:
X-link: pytorch/pytorch#107014

Create fastpath backend context manager, similar to SDPA kernel backend manager

Differential Revision: D48256968

fbshipit-source-id: dc0f6ef9cd4dde28a08ffca26d7e32b090e0bf33

mikekgfb mentioned this pull request

Create fastpath backend context manager, similar to SDPA kernel backend manager facebook/TestSlide#356

Closed


          Create fastpath backend context manager, similar to SDPA kernel backe…

8b3d1ad

…nd manager

Summary: Create fastpath backend context manager, similar to SDPA kernel backend manager

Test Plan: sandcastle, github

Differential Revision: D48256968

fbshipit-source-id: e77e589a0ce3055423097ceafd4891b94f151afc

Contributor

facebook-github-bot commented Aug 14, 2023

This pull request was exported from Phabricator. Differential Revision: D48256968

mikekgfb force-pushed the export-D48256968 branch from c0b52a0 to 8b3d1ad Compare

August 14, 2023 19:16

Contributor

github-actions bot commented Oct 13, 2023

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions bot added the Stale label

github-actions bot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mrshenli Awaiting requested review from mrshenli

zhaojuanmao Awaiting requested review from zhaojuanmao

rohan-varma Awaiting requested review from rohan-varma

H-Huang Awaiting requested review from H-Huang

awgu Awaiting requested review from awgu

kwen2501 Awaiting requested review from kwen2501

wanchaol Awaiting requested review from wanchaol

fegin Awaiting requested review from fegin

fduwjj Awaiting requested review from fduwjj

jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

drisspg Awaiting requested review from drisspg

Labels

fb-exported release notes: distributed (fsdp) release notes: nn Stale