Closed
Conversation
houseroad
reviewed
Aug 20, 2018
Member
houseroad
left a comment
There was a problem hiding this comment.
Looks good. Can you add some test in https://github.com/pytorch/pytorch/blob/master/test/onnx/test_operators.py?
added 2 commits
August 20, 2018 11:55
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
MisterTea has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Pull Request resolved: pytorch#10694 Reviewed By: houseroad Differential Revision: D9405612 Pulled By: MisterTea fbshipit-source-id: 6d83d3c2db933a3822076c7faf578ac0e92e60c6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.