Make InternalModel and Resnet work with rexportable flow#106676

Closed

tugsbayasgalan wants to merge 1 commit intopytorch:mainfrom

tugsbayasgalan:export-D47890878

Contributor

tugsbayasgalan commented Aug 6, 2023 •

edited

Loading

Summary: Internal model and Resnet uses "re-export" flow now. Also did some refactoring to make the code little cleaner

Some changes for OSS:

Correctly use the "cached" fake tensors so that static symbols are still resolved to static
Change logic in PassBase to allocate static shapes for parameters
Add "is_torch_exported" tag to every node to make it survive during various graph transformations.
Added experimental wrapper API for quantization team to get pre_dispatch=True graph. Note that it doesn't actually do that right now. But we plan to switch soon.

Test Plan: CI

Differential Revision: D47890878

pytorch-bot Bot commented Aug 6, 2023 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106676

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

ROCm CI upgrade in progress

✅ 2 Unrelated Failures

As of commit 7206b23:

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

github-actions Bot added the module: export label

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Aug 6, 2023

This pull request was exported from Phabricator. Differential Revision: D47890878

tugsbayasgalan mentioned this pull request

Make Internal model and Resnet work with rexportable flow pytorch/executorch#40

Closed

tugsbayasgalan changed the title ~~Make MilanDictation and Resnet work with rexportable flow~~ Make InternalModel and Resnet work with rexportable flow

tugsbayasgalan force-pushed the export-D47890878 branch from 1b537a5 to ac5ea9c Compare

August 6, 2023 08:04

Contributor

facebook-github-bot commented Aug 6, 2023

This pull request was exported from Phabricator. Differential Revision: D47890878

tugsbayasgalan force-pushed the export-D47890878 branch from ac5ea9c to adf4e1e Compare

August 8, 2023 03:32

tugsbayasgalan requested a review from jerryzh168 as a code owner

August 8, 2023 03:32

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47890878

github-actions Bot added the release notes: quantization label

tugsbayasgalan added the topic: not user facing label

tugsbayasgalan force-pushed the export-D47890878 branch from adf4e1e to ea3f8af Compare

August 8, 2023 18:40

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47890878

1 similar comment

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47890878

tugsbayasgalan force-pushed the export-D47890878 branch from ea3f8af to 73bf81e Compare

August 8, 2023 18:49

jerryzh168 reviewed

View reviewed changes

torch/_export/__init__.py Outdated

Contributor

jerryzh168 Aug 8, 2023

can you add some docs about plans for this API

Contributor Author

tugsbayasgalan Aug 9, 2023

just added

tugsbayasgalan force-pushed the export-D47890878 branch from 73bf81e to 1d6b692 Compare

August 8, 2023 21:59

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47890878

tugsbayasgalan force-pushed the export-D47890878 branch from 1d6b692 to db9096d Compare

August 8, 2023 22:51

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47890878

tugsbayasgalan requested a review from jerryzh168

August 8, 2023 22:53

tugsbayasgalan force-pushed the export-D47890878 branch from db9096d to 5265c97 Compare

August 8, 2023 22:58

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47890878

tugsbayasgalan force-pushed the export-D47890878 branch from 5265c97 to 49ad872 Compare

August 8, 2023 23:07

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47890878

tugsbayasgalan force-pushed the export-D47890878 branch from 49ad872 to 879711c Compare

August 8, 2023 23:17

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47890878


          Make Resnet work with rexportable flow (pytorch#106676)

7206b23

Test Plan: CI

Differential Revision: D47890878

fbshipit-source-id: 50f0e12f60f6a37dab5e30d22122882594fd6227

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D47890878

tugsbayasgalan force-pushed the export-D47890878 branch from 879711c to 7206b23 Compare

August 8, 2023 23:32

jerryzh168 approved these changes

View reviewed changes

Contributor

jerryzh168 left a comment

quant changes looks good to me, do you need review from some compiler people as well?

tugsbayasgalan requested a review from zhxchen17

August 9, 2023 02:21

Contributor Author

tugsbayasgalan commented Aug 9, 2023

quant changes looks good to me, do you need review from some compiler people as well?

Sounds good! I will merge after I get review from Zhengxu.

Contributor

facebook-github-bot commented Aug 9, 2023

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot Bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Aug 9, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added Merged and removed merging labels

pytorchmergebot closed this in

a44c072

Cyril-Anto pushed a commit to Cyril-Anto/pytorch that referenced this pull request


          Make InternalModel and Resnet work with rexportable flow (pytorch#106676

ab37b03

)

Summary: Internal model and Resnet uses "re-export" flow now. Also did some refactoring to make the code little cleaner

Some changes for OSS:
1. Correctly use the "cached" fake tensors so that static symbols are still resolved to static
2. Change logic in PassBase to allocate static shapes for parameters
3. Add "is_torch_exported" tag to every node to make it survive during various graph transformations.
4. Added experimental wrapper API for quantization team to get pre_dispatch=True graph. Note that it doesn't actually do that right now. But we plan to switch soon.

Test Plan: CI

Differential Revision: D47890878

Pull Request resolved: pytorch#106676
Approved by: https://github.com/jerryzh168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk fb-exported Merged release notes: quantization topic: not user facing