[Caffe2] GCC-7 doesn't like the original syntax.#10665
Closed
xkszltl wants to merge 1 commit intopytorch:masterfrom
Closed
[Caffe2] GCC-7 doesn't like the original syntax.#10665xkszltl wants to merge 1 commit intopytorch:masterfrom
xkszltl wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
Author
|
Also recommend adding gcc7-CUDA build. |
ezyang
approved these changes
Aug 19, 2018
Replace with "this->template f<T>()".
Contributor
Author
|
Any concern on merging this? Thanks |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Replace with "this->template f<T>()". Fix pytorch#7881 Pull Request resolved: pytorch#10665 Differential Revision: D9597187 Pulled By: ezyang fbshipit-source-id: 8af4e7efd98edadabb97e2523a58bd21bc116d1a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace with "this->template f()".
Fix #7881