Closed
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
apaszke has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
reviewed
Aug 19, 2018
| struct DropoutState { | ||
| // Both buffer and event are lazily instantiated when a dropout state is needed | ||
| // for the first time. Note that in this case needed != used, as we don't need | ||
| // a bufer to e.g. run RNNs in test mode. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
reviewed
Aug 19, 2018
| // a bufer to e.g. run RNNs in test mode. | ||
| at::Tensor buffer; | ||
| cuda::CUDAEvent event; | ||
| at::optional<cuda::CUDAEvent> event; |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
soumith
approved these changes
Aug 20, 2018
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Aug 20, 2018
Summary: Minor fix for the cuDNN cache. Previously we would skip the event reinitialization when an RNN function would be called on GPU 0, and then on GPU 1, but it would be in eval mode on GPU1. That would cause us to skip event re-initialization, and cause an incorrect resource handle error when trying to record the event. soumith Pull Request resolved: pytorch/pytorch#10662 Reviewed By: soumith Differential Revision: D9393629 Pulled By: apaszke fbshipit-source-id: e64c1c1d2860e80f5a7ba727d0b01aeb5f762d90
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Minor fix for the cuDNN cache. Previously we would skip the event reinitialization when an RNN function would be called on GPU 0, and then on GPU 1, but it would be in eval mode on GPU1. That would cause us to skip event re-initialization, and cause an incorrect resource handle error when trying to record the event. soumith Pull Request resolved: pytorch#10662 Reviewed By: soumith Differential Revision: D9393629 Pulled By: apaszke fbshipit-source-id: e64c1c1d2860e80f5a7ba727d0b01aeb5f762d90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor fix for the cuDNN cache. Previously we would skip the event reinitialization when an RNN function would be called on GPU 0, and then on GPU 1, but it would be in eval mode on GPU1. That would cause us to skip event re-initialization, and cause an incorrect resource handle error when trying to record the event.
@soumith