Skip to content

Minor update to ROCm triton commit pin#106616

Closed
jataylo wants to merge 1 commit intomainfrom
rocm-triton-nightly-wheelfix
Closed

Minor update to ROCm triton commit pin#106616
jataylo wants to merge 1 commit intomainfrom
rocm-triton-nightly-wheelfix

Conversation

@jataylo
Copy link
Copy Markdown
Collaborator

@jataylo jataylo commented Aug 4, 2023 •
edited by pytorch-bot bot
Loading

This is required for a fix in latest nightly wheels in which the hip_runtime header file cannot be found during triton lowering

/tmp/tmpqoq6gtl8/main.c:3:14: fatal error: hip/hip_runtime.h: No such file or directory
3 | #include <hip/hip_runtime.h>
| ^~~~~~~~~~~~~~~~~~~

This is a single commit update to bring in this change
ROCm/triton#283

cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport @dllehr-amd @hongxiayang

@jataylo
Minor update to ROCm triton commit pin
7f03f6a 
This is required for a fix in latest nightly wheels
@jataylo jataylo added module: rocm AMD GPU support for Pytorch ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR rocm This tag is for PRs from ROCm team ciflow/unstable Run all experimental or flaky jobs on PyTorch unstable workflow ciflow/slow labels Aug 4, 2023
@jataylo jataylo requested a review from malfet August 4, 2023 15:30
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 4, 2023
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Aug 4, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106616

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 7f03f6a:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@jataylo jataylo requested a review from jithunnair-amd August 4, 2023 15:31
@jataylo jataylo marked this pull request as ready for review August 6, 2023 16:39
@jataylo jataylo requested a review from jeffdaily as a code owner August 6, 2023 16:39
@jataylo jataylo requested a review from kit1980 August 6, 2023 16:39
@jataylo
Copy link
Copy Markdown
Collaborator Author

jataylo commented Aug 6, 2023

Hi @malfet @kit1980, just updating our triton rocm commit one commit forwards to fix an issue in our latest nightly wheels. There has been some directory changes in triton we needed to update in our wheels in order to find relevant ROCm libs and headers.

malfet
malfet approved these changes Aug 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@jithunnair-amd can you please confirm, that all trition-rocm pins should be committed to https://github.com/ROCmSoftwarePlatform/triton/tree/triton-mlir-pyt-latest branch?

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Aug 6, 2023

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Aug 6, 2023

Merge started

Your change will be merged while ignoring the following 1 checks: inductor / linux-focal-cpu-py3.8-gcc7-inductor / test (inductor_torchbench_cpu_accuracy, 1, 1, linux.4xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jithunnair-amd
Copy link
Copy Markdown
Collaborator

jithunnair-amd commented Aug 6, 2023

Hi @malfet @kit1980, just updating our triton rocm commit one commit forwards to fix an issue in our latest nightly wheels. There has been some directory changes in triton we needed to update in our wheels in order to find relevant ROCm libs and headers.

Yes, for the nightly wheels, that's the triton branch we are using.

@jataylo jataylo mentioned this pull request Aug 14, 2023
Closed
Cyril-Anto pushed a commit to Cyril-Anto/pytorch that referenced this pull request Aug 17, 2023
@jataylo @Cyril-Anto
Minor update to ROCm triton commit pin (pytorch#106616)
e934f12 
This is required for a fix in latest nightly wheels in which the hip_runtime header file cannot be found during triton lowering

```
/tmp/tmpqoq6gtl8/main.c:3:14: fatal error: hip/hip_runtime.h: No such file or directory
3 | #include <hip/hip_runtime.h>
| ^~~~~~~~~~~~~~~~~~~
```

This is a single commit update to bring in this change
ROCm/triton#283

Pull Request resolved: pytorch#106616
Approved by: https://github.com/malfet
@github-actions github-actions bot deleted the rocm-triton-nightly-wheelfix branch February 3, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

@kit1980 kit1980 Awaiting requested review from kit1980

Assignees

No one assigned

Labels

ciflow/inductor ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/slow ciflow/trunk Trigger trunk jobs on your pull request ciflow/unstable Run all experimental or flaky jobs on PyTorch unstable workflow Merged module: rocm AMD GPU support for Pytorch open source rocm This tag is for PRs from ROCm team topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jataylo @malfet @pytorchmergebot @jithunnair-amd @pytorchbot