[pt2] add metas for mode ops#106273
Closed
nkaretnikov wants to merge 4 commits intogh/nkaretnikov/162/basefrom
Closed
[pt2] add metas for mode ops#106273nkaretnikov wants to merge 4 commits intogh/nkaretnikov/162/basefrom
mode ops#106273nkaretnikov wants to merge 4 commits intogh/nkaretnikov/162/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106273
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0ea9809: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
nkaretnikov
commented
Jul 30, 2023
| ) | ||
| @out_wrapper("values", "indices") | ||
| def meta_median_dim(input, dim=-1, keepdim=False): | ||
| def meta_median_mode_dim(input, dim=-1, keepdim=False): |
Collaborator
Author
There was a problem hiding this comment.
Same as median, but mode has one less aten variant (no variant without dim param).
Collaborator
Author
|
From the list in #105105 |
[ghstack-poisoned]
[ghstack-poisoned]
ezyang
approved these changes
Jul 31, 2023
[ghstack-poisoned]
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
modeops #106273medianops #106272