Skip to content

Change _dynamo.export to be export(f)(*args, **kwargs)#106109

Closed
ezyang wants to merge 7 commits intogh/ezyang/2268/basefrom
gh/ezyang/2268/head
Closed

Change _dynamo.export to be export(f)(*args, **kwargs)#106109
ezyang wants to merge 7 commits intogh/ezyang/2268/basefrom
gh/ezyang/2268/head

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Jul 27, 2023

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 27, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/106109

Note: Links to docs will display an error until the docs builds have been completed.

✅ 1 Unrelated Failure

As of commit f1c7c37:

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jul 27, 2023
@github-actions github-actions bot requested a review from albanD July 27, 2023 03:46
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
@github-actions github-actions bot added the release notes: quantization release notes category label Jul 27, 2023
@ezyang ezyang added module: bc-breaking Related to a BC-breaking change topic: bc breaking topic category topic: new features topic category labels Jul 27, 2023
@albanD albanD removed their request for review July 27, 2023 13:52
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc gchanan voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
@ezyang ezyang added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 27, 2023
@ezyang
Copy link
Contributor Author

ezyang commented Jul 27, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc gchanan voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx ipiszy chenyang78 aakhundov

[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Jul 27, 2023

@pytorchbot merge -f "lint only"

ezyang added a commit that referenced this pull request Jul 27, 2023
Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: ff59877
Pull Request resolved: #106109
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

facebook-github-bot pushed a commit to pytorch/executorch that referenced this pull request Jul 29, 2023
Summary:
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

X-link: pytorch/pytorch#106109
Approved by: https://github.com/voznesenskym

bypass-github-export-checks

Reviewed By: PaliC

Differential Revision: D47860637

Pulled By: ezyang

fbshipit-source-id: 3933e3ffc43929f27ca4d3dc44a9bc822e8bc8db
bobby-palmer pushed a commit to bobby-palmer/pytorch that referenced this pull request Jul 29, 2023
Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: pytorch#106109
Approved by: https://github.com/voznesenskym
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/2268/head branch July 31, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: bc-breaking Related to a BC-breaking change module: dynamo release notes: export release notes: onnx torch.onnx related changes that should show up in the release notes release notes: quantization release notes category topic: bc breaking topic category topic: new features topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants